JavaScript: Teach IncompleteSanitization to recognize incomplete URI {en,de}coding.
#43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…L {en,de}coding.
asger-semmle
approved these changes
Aug 10, 2018
| m.regexpMatch(urlEscapePattern) | ||
| or | ||
| // URL encoder | ||
| repl.getArgument(1).getStringValue().regexpMatch(urlEscapePattern) |
There was a problem hiding this comment.
Not a real problem in this case, but it does bother me a bit that m isn't bound in the last case. It's not that obvious that there is no cartesian product here.
There was a problem hiding this comment.
I can pull it out of the exists if you like and add and exists(getAMatchedString(old)) instead (that bit is important to avoid false positives from cases where we cannot analyse old).
There was a problem hiding this comment.
Ah right, if the exists matters then let's keep it like this.
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Oct 28, 2021
Kotlin: Towards KotlinType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finds a good number of new results, most of which are obviously true positives.