JavaScript: Add WebView-related taint sinks for CodeInjection, DomBasedXss and ServerSideUrlRedirect.
#48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 10, 2018 15:59
…omBasedXss` and `ServerSideUrlRedirect`.
|
I was going to suggest that we check for the flag javaScriptEnabled which can be used to turn off JavaScript in the web view. On the other hand, allowing non-scripted html injection can still be pretty bad, and looking at the docs now, it seems the flag only works on Android(?!). What do you think? Otherwise LGTM. |
|
Yes, I saw that, but as you say it only seems to apply to Android. I didn't really understand whether it was just always enabled on iOS or whether you could turn it off there as well (in which case it would be the same as on Android, so that's probably not it). In the end, I decided to just ignore it for now. |
asger-semmle
approved these changes
Aug 10, 2018
aibaars
pushed a commit
that referenced
this pull request
Oct 14, 2021
Check query compilation and formatting in `qltest.yml`
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Oct 28, 2021
Kotlin: Fix File locations, and fromSource/hasSourceLocation for Kotlin code
erik-krogh
pushed a commit
to erik-krogh/ql
that referenced
this pull request
Dec 15, 2021
Make the create-extractor-pack.ps1 script more reliable.
erik-krogh
pushed a commit
to erik-krogh/ql
that referenced
this pull request
Dec 15, 2021
Make the create-extractor-pack.ps1 script more reliable.
dbartol
pushed a commit
that referenced
this pull request
Dec 18, 2024
…step new untrusted checkout step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a small evaluation on four projects that use
WebViewincluding VSCode and TinyMCE. Performance was unchanged and there were no new results. I can run a larger-scale evaluation over the weekend if desired.