Skip to content

JavaScript: Demote HeterogenousComparison to warning level. #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xiemaisi
Copy link

In practice, this query tends to flag superfluous but harmless tests rather than actual bugs.

@xiemaisi xiemaisi requested a review from asger-semmle August 14, 2018 14:56
@xiemaisi xiemaisi requested a review from a team as a code owner August 14, 2018 14:56
Copy link
Contributor

@asger-semmle asger-semmle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@semmle-qlci semmle-qlci merged commit 8e5059f into github:master Aug 15, 2018
@xiemaisi xiemaisi deleted the js/demote-heterogeneous-comparison branch August 15, 2018 08:02
aibaars pushed a commit that referenced this pull request Oct 14, 2021
Add `Pattern::getAVariable()` and use `self` range field throughout
smowton pushed a commit to smowton/codeql that referenced this pull request Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants