InlineExpectationsTest: Allow URLs as values #8530
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example,
```py
requests.get("http://example.com") # $ clientRequestUrlPart="http://example.com"
```
would not have been allowed previously, since the `//` part of the value
for the URL would have caused the rest of the line to be treated as a
normal (non-interpreted) comment.
Requiring a space before the `//` allows this specific example, while
still support all the existing uses of `//` to break expectation tests,
which is usually to add a comment explaining why the annotation is like
it is.
RasmusWL
force-pushed
the
inline-expectation-tests-allow-urls
branch
from
f31ff96 to
6d3ad95
Compare
|
@dbartol just wanted to check whether you would be OK with this change? (before pinging all the other language teams) |
|
Note that |
Sure thing, I'll do if the overall idea is accepted 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example,
would not have been allowed previously, since the
//part of the value for the URL would have caused the rest of the line to be treated as a normal (non-interpreted) comment.Requiring a space before the
//allows this specific example, while still support all the existing uses of//to break expectation tests, which is usually to add a comment explaining why the annotation is like it is.