C++: add range analysis diff test #8665
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
previously approved these changes
Apr 17, 2022
| @@ -1,4 +1,4 @@ | |||
| template<typename T> void mod(T value); | |||
| /*template<typename T> void mod(T value); | |||
There was a problem hiding this comment.
Should this still be commented out?
| IR::Operand asOperand() { none() } | ||
| } | ||
|
|
||
| class SsaInstructionVariable extends SsaVariable, TSsaInstruction { |
There was a problem hiding this comment.
This class can probably be private, no?
| final override IR::Instruction asInstruction() { result = instr } | ||
| } | ||
|
|
||
| class SsaOperand extends SsaVariable, TSsaOperand { |
There was a problem hiding this comment.
This class can be private, right? And could we call it SsaOperandVariable for consistency?
This makes inexact memory operands into their own SSA variables in the Semantic interface, which resolves an issue with phi nodes losing inexact operands (e.g. the unknown-size variable for parameter indirections).
rdmarsh2
force-pushed
the
rdmarsh2/sem-range-diff-test
branch
from
2d7a7d3 to
9f5cd71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.