Skip to content

Commit 0676116

Browse files
authored
fix build script exit code and fix typo in README (#1472)
1 parent 42c0f08 commit 0676116

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ Please see [Coding gh-ost](doc/coding-ghost.md) for a guide to getting started d
9797

9898
`gh-ost` is a Go project; it is built with Go `1.15` and above. To build on your own, use either:
9999
- [script/build](https://github.com/github/gh-ost/blob/master/script/build) - this is the same build script used by CI hence the authoritative; artifact is `./bin/gh-ost` binary.
100-
- [build.sh](https://github.com/github/gh-ost/blob/master/build.sh) for building `tar.gz` artifacts in `/tmp/gh-ost`
100+
- [build.sh](https://github.com/github/gh-ost/blob/master/build.sh) for building `tar.gz` artifacts in `/tmp/gh-ost-release`
101101

102102
Generally speaking, `master` branch is stable, but only [releases](https://github.com/github/gh-ost/releases) are to be used in production.
103103

build.sh

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
#!/bin/bash
2-
#
3-
#
42

53
RELEASE_VERSION=
64
buildpath=
@@ -72,11 +70,14 @@ main() {
7270
build macOS osx darwin amd64
7371
build macOS osx darwin arm64
7472

73+
bin_files=$(find $buildpath/gh-ost* -type f -maxdepth 1)
7574
echo "Binaries found in:"
76-
find $buildpath/gh-ost* -type f -maxdepth 1
75+
echo "$bin_files"
7776

7877
echo "Checksums:"
79-
(cd $buildpath && shasum -a256 gh-ost* 2>/dev/null)
78+
(shasum -a256 $bin_files 2>/dev/null)
79+
80+
echo "Build Success!"
8081
}
8182

8283
main "$@"

0 commit comments

Comments
 (0)