Add support for experiment after_run blocks #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow an experiment to run custom behavior based on experiment
results, eg:
class MyWidget
include Scientist
def users
science "my-experiment" do |e|
e.use { control_method }
e.try { candidate_method }
# Slower candidates need further investigation
e.after_run do |result|
control_duration = result.control.duration
candidate_duration = result.candidates.first.duration
if candidate_duration - control_duration > 15
Logger.debug("Slow experiment candidate #{context}")
end
end
end
end
end
zerowidth
reviewed
Apr 5, 2023
lib/scientist/experiment.rb
Outdated
| # Define a block of code to run after an experiment completes, if the experiment | ||
| # is enabled. | ||
| # | ||
| # The block takes no arguments. |
There was a problem hiding this comment.
The block takes the result of the experiment as the argument, right?
There was a problem hiding this comment.
It does, thanks for catching that! Fixed in 6ea1efc.
zerowidth
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows an experiment to run custom behavior based on experiment results, eg