Skip to content

Conversation

@vovanec
Copy link

@vovanec vovanec commented Mar 1, 2021

Fixed race condition which resulted in inconsistent error code on missing copyright header.

Fixed race condition which resulted in inconsistent error code on missing copyright header.
@google-cla
Copy link

google-cla bot commented Mar 1, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@vovanec
Copy link
Author

vovanec commented Mar 1, 2021

@googlebot I signed it!

@vovanec vovanec changed the title Fixed race condition Fixed race condition which results in inconsistent error code on missing copyright header. Mar 1, 2021
@vovanec
Copy link
Author

vovanec commented Mar 2, 2021

Is there ANY ongoing activity for this project? I see a bunch of merge requests opened without any update. If it's not something actively maintained by anybody, I can take over or simply do my own fork. Let me know.

Copy link
Contributor

@flwyd flwyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to addlicense! I've picked up ownership after the previous maintainers moved on.

close(ch)
<-done
if err := <-done; err != nil {
fmt.Printf("error: %s\n", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the error paths do a log.Printf already, and it seems weird to print the error to stdout. Is this line needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants