refactor: use custom NotFoundError when session is not found, instead of ValueError #1384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Tobias-Freire , could you resolve the conflict for this PR? |
DeanChensj
added
the
wip
DeanChensj
reviewed
Jul 30, 2025
There was a problem hiding this comment.
nit. the test and your change are actually irrelevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done
ValueErrorforNotFoundErrorwhen session not found in adk-python/src/google/adk/runners.pyValueErrorforNotFoundErrorin apropriated parts of code in adk-python/tests/unittests/sessions/test_vertex_ai_session_service.pyMotivation
Improves code readability and maintainability.
Issue
Closes #1383