Skip to content

[libhoclient] upload artifacts #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2025
Merged

[libhoclient] upload artifacts #1250

merged 2 commits into from
Jun 20, 2025

Conversation

ser-io
Copy link
Member

@ser-io ser-io commented Jun 9, 2025

No description provided.

@ser-io ser-io marked this pull request as ready for review June 9, 2025 21:04
@ser-io ser-io requested review from 0405ysj and jemoreira June 9, 2025 21:04
@ser-io
Copy link
Member Author

ser-io commented Jun 9, 2025 •
edited
Loading

Reusing work done in #1165

@ser-io ser-io force-pushed the ho-client-upload branch from 952090a to 147635d Compare June 9, 2025 23:49
0405ysj
0405ysj requested changes Jun 10, 2025
View reviewed changes
@0405ysj
Copy link
Collaborator

0405ysj commented Jun 10, 2025

Though it's not the scope of this PR, are you willing to implement libhoclient code for HO extract API as well? I'm having a plan to implement that after this PR being merged, I want to know your plan before working on it. Anyway, thanks for your effort on libhoclient code!

@ser-io
Copy link
Member Author

ser-io commented Jun 10, 2025

Though it's not the scope of this PR, are you willing to implement libhoclient code for HO extract API as well? I'm having a plan to implement that after this PR being merged, I want to know your plan before working on it. Anyway, thanks for your effort on libhoclient code!

I won't be implementing the modifications needed for the new extract API. You can go ahead and implement it.

0405ysj
0405ysj reviewed Jun 11, 2025
View reviewed changes
@0405ysj
Copy link
Collaborator

0405ysj commented Jun 13, 2025

Any updates?

@ser-io ser-io force-pushed the ho-client-upload branch 2 times, most recently from 543765f to 5b0e77b Compare June 13, 2025 21:59
@ser-io ser-io requested a review from 0405ysj June 13, 2025 22:07
@ser-io ser-io force-pushed the ho-client-upload branch from 5b0e77b to aeda75b Compare June 13, 2025 22:23
@ser-io ser-io changed the title [libhoclient] consume new user artifacts endpoints. [libhoclient] upload artifacts Jun 13, 2025
@ser-io ser-io force-pushed the ho-client-upload branch from aeda75b to ad0347e Compare June 13, 2025 22:27
0405ysj
0405ysj reviewed Jun 16, 2025
View reviewed changes
Copy link
Collaborator

@0405ysj 0405ysj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might miss your change written in e2etests/orchestration/upload_artifact_test/main_test.go before, sorry for that. Except E2E test, PR looks good to me.

@ser-io ser-io force-pushed the ho-client-upload branch from ad0347e to 7a46e37 Compare June 16, 2025 16:17
@ser-io ser-io requested a review from 0405ysj June 16, 2025 16:22
@ser-io ser-io added this pull request to the merge queue Jun 20, 2025
Merged via the queue into google:main with commit 036ea96 Jun 20, 2025
17 checks passed
@ser-io ser-io deleted the ho-client-upload branch June 20, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0405ysj 0405ysj

@jemoreira jemoreira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ser-io @0405ysj