Create a type to represent the metadata image. #1271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jemoreira
approved these changes
Jun 16, 2025
base/cvd/cuttlefish/host/commands/assemble_cvd/disk/metadata_image.cc
Outdated
Show resolved
Hide resolved
cjreynol
approved these changes
Jun 16, 2025
base/cvd/cuttlefish/host/commands/assemble_cvd/disk/metadata_image.cc
Outdated
Show resolved
Hide resolved
The type provides access to the path of the metadata image, given that the file satisfies the constraints we impose on it. This means that accessing the file path guarantees that the file is created with the right constraints. More specifically: - Remove metadata-specific members from `CuttlefishConfig::InstanceSpecific`. - Remove the `--blank_metadata_image_mb` flag. This has no users in Android CI. - Enforce the `metadata.img` name is only referenced in one place. Bug: b/424863187
|
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type provides access to the path of the metadata image, given that the file satisfies the constraints we impose on it. This means that accessing the file path guarantees that the file is created with the right constraints.
More specifically:
CuttlefishConfig::InstanceSpecific.--blank_metadata_image_mbflag. This has no users in Android CI.metadata.imgname is only referenced in one place.Bug: b/424863187