Don't use test files #1277
Merged
Don't use test files #1277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ser-io
approved these changes
Jun 16, 2025
0405ysj
approved these changes
Jun 17, 2025
frontend/src/host_orchestrator/orchestrator/userartifacts_test.go
Outdated
Show resolved
Hide resolved
0405ysj
reviewed
Jun 17, 2025
frontend/src/host_orchestrator/orchestrator/userartifacts_test.go
Outdated
Show resolved
Hide resolved
jemoreira
force-pushed
the
main
branch
2 times, most recently
from
63ba2be to
bca271e
Compare
0405ysj
reviewed
Jun 17, 2025
frontend/src/host_orchestrator/orchestrator/userartifacts_test.go
Outdated
Show resolved
Hide resolved
frontend/src/host_orchestrator/orchestrator/userartifacts_test.go
Outdated
Show resolved
Hide resolved
0405ysj
reviewed
Jun 17, 2025
frontend/src/host_orchestrator/orchestrator/userartifacts_test.go
Outdated
Show resolved
Hide resolved
frontend/src/host_orchestrator/orchestrator/userartifacts_test.go
Outdated
Show resolved
Hide resolved
frontend/src/host_orchestrator/orchestrator/userartifacts_test.go
Outdated
Show resolved
Hide resolved
jemoreira
force-pushed
the
main
branch
3 times, most recently
from
6c41136 to
e1f6ff3
Compare
jemoreira
changed the title
0405ysj
approved these changes
Jun 18, 2025
There was a problem hiding this comment.
LGTM. Could you fix other presubmit check failures caused by Golang version? Thanks!
+ go test ./...
go: downloading github.com/google/go-cmp v0.5.9
# github.com/google/android-cuttlefish/frontend/src/host_orchestrator/orchestrator [github.com/google/android-cuttlefish/frontend/src/host_orchestrator/orchestrator.test]
orchestrator/userartifacts_test.go:446:18: undefined: os.CreateTemp
orchestrator/userartifacts_test.go:535:18: undefined: os.CreateTemp
note: module requires Go 1.17
? github.com/google/android-cuttlefish/frontend/src/host_orchestrator [no test files]
? github.com/google/android-cuttlefish/frontend/src/host_orchestrator/api/v1 [no test files]
FAIL github.com/google/android-cuttlefish/frontend/src/host_orchestrator/orchestrator [build failed]
ok github.com/google/android-cuttlefish/frontend/src/host_orchestrator/orchestrator/cvd 0.002s
? github.com/google/android-cuttlefish/frontend/src/host_orchestrator/orchestrator/debug [no test files]
? github.com/google/android-cuttlefish/frontend/src/host_orchestrator/orchestrator/exec [no test files]
? github.com/google/android-cuttlefish/frontend/src/host_orchestrator/orchestrator/testing [no test files]
FAIL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write test archives during test execution instead of depending on existing files. Existing files don't work when the test is executed in a sandboxed environment.