-
Notifications
You must be signed in to change notification settings - Fork 167
Add C++ wrapper classes for libzip #1278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bug: b/425534816
Can you update adb and fastboot as well? I forked both to use libzip as requested, and they are both C++. |
Bug: b/425534816
Bug: b/425534816
Bug: b/425534816
I'm starting to regret bringing that up. IIUC https://www.github.com/nih-at/libzip/issues/82 explicitly says this is unsupported in libzip. |
Bug: b/425534816
Bug: b/425534816
Bug: b/425534816
I wasn't sure about this either, and honestly, I didn't test it, but it looks like adb is permitted to fall back to --no-incremental if the device doesn't support incfs (we do), so I think it would be better to just remove or disable the incremental code altogether and delete the dependency. |
There's a lot of raw pointer management in existing usage:
Bug: b/425534816