Skip to content

Conversation

@Databean Databean requested a review from jemoreira June 17, 2025 05:27
@Databean Databean changed the title Add a C++ wrapper class for libzip Add C++ wrapper classes for libzip Jun 17, 2025
@adelva1984
Copy link
Collaborator

Can you update adb and fastboot as well? I forked both to use libzip as requested, and they are both C++.

@Databean
Copy link
Member Author

Databean commented Jun 17, 2025

I forked both to use libzip as requested

I'm starting to regret bringing that up.

IIUC adb uses ZipArchive to find the offsets where zip file members start. I'm not sure I trust zip_source_tell to find these locations while a zip_t is moving around the seek offsets in the underlying zip_source_t, and I don't see anything else in libzip that exposes this information.

https://www.github.com/nih-at/libzip/issues/82 explicitly says this is unsupported in libzip.

@adelva1984
Copy link
Collaborator

I forked both to use libzip as requested
...
https://www.github.com/nih-at/libzip/issues/82 explicitly says this is unsupported in libzip.

I wasn't sure about this either, and honestly, I didn't test it, but it looks like adb is permitted to fall back to --no-incremental if the device doesn't support incfs (we do), so I think it would be better to just remove or disable the incremental code altogether and delete the dependency.

@Databean Databean added this pull request to the merge queue Jun 18, 2025
Merged via the queue into google:main with commit cf5aa67 Jun 18, 2025
17 checks passed
@Databean Databean deleted the zip branch August 6, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants