feat: handle kafka errors that require to refresh metadata #5253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiermolinar
requested review from
joe-elliott,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham,
stoewer and
carles-grafana
as code owners
mapno
reviewed
Jun 18, 2025
Comment on lines
+210
to
+212
| func() { | ||
| b.kafkaClient.ForceMetadataRefresh() | ||
| }) |
There was a problem hiding this comment.
You can pass the function directly without wrapping it.
Suggested change
| func() { | |
| b.kafkaClient.ForceMetadataRefresh() | |
| }) | |
| b.kafkaClient.ForceMetadataRefresh |
Comment on lines
+524
to
+533
| for boff.Ongoing() { | ||
| commits, endsOffsets, err = b.getPartitionOffsets(ctx) | ||
| if err == nil { | ||
| break | ||
| } | ||
| retryable := ingest.HandleKafkaError(err, b.kafkaClient.ForceMetadataRefresh) | ||
| if retryable { | ||
| boff.Wait() | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't understand this loop and a similar one in metrics.go, if the error is non-retryable it retries it immediately anyway while the back-off is still ongoing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Some Kafka errors require to refresh the client metadata:
error level=erro caller=metrics.go:58 msg="metric lag failed:" err="request ListOffsets has 1 separate shard errors, first: unknown broker"or
We want to ensure that the client metadata is not stale and in the case of "unknownBroker" retry the operation. It adds a backoff strategy to handle the retries.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]