Build failure because of failing tests

I have problems building the library for the nar-maven-plugin because of failing tests:

[INFO] Scanning for projects...
[INFO]                                                                         
[INFO] ------------------------------------------------------------------------
[INFO] Building CPPTasks (parallel) 1.0-beta-5-parallel-1-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO] 
[INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ cpptasks-parallel ---
[INFO] Deleting D:\Downloads\Temp\maven-nar\cpptasks-parallel-master\cpptasks-parallel-master\target
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ cpptasks-parallel ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 5 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ cpptasks-parallel ---
[INFO] Compiling 190 source files to D:\Downloads\Temp\maven-nar\cpptasks-parallel-master\cpptasks-parallel-master\target\classes
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cpptasks-parallel ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 4 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @ cpptasks-parallel ---
[INFO] Compiling 40 source files to D:\Downloads\Temp\maven-nar\cpptasks-parallel-master\cpptasks-parallel-master\target\test-classes
[INFO] 
[INFO] --- maven-surefire-plugin:2.6:test (default-test) @ cpptasks-parallel ---
[INFO] Surefire report directory: D:\Downloads\Temp\maven-nar\cpptasks-parallel-master\cpptasks-parallel-master\target\surefire-reports

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running net.sf.antcontrib.cpptasks.sun.TestForteCCCompiler
Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.031 sec
Running net.sf.antcontrib.cpptasks.TestTargetHistoryTable
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.174 sec
Running net.sf.antcontrib.cpptasks.parser.TestFortranParser
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.014 sec
Running net.sf.antcontrib.cpptasks.TestCompilerEnum
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.026 sec
Running net.sf.antcontrib.cpptasks.devstudio.TestDevStudioLinker
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.023 sec
Running net.sf.antcontrib.cpptasks.TestAllClasses
Class: CompilerDef and: CompilerDef
Tests run: 236, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 11.177 sec <<< FAILURE!
Running net.sf.antcontrib.cpptasks.ibm.TestVisualAgeCCompiler
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec
Running net.sf.antcontrib.cpptasks.gcc.TestGccCCompiler
Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec
Running net.sf.antcontrib.cpptasks.TestDependencyTable
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.107 sec
Running net.sf.antcontrib.cpptasks.TestLinkerDef
Tests run: 28, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.019 sec
Running net.sf.antcontrib.cpptasks.devstudio.TestDevStudioCCompiler
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec
Running net.sf.antcontrib.cpptasks.TestCUtil
Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec
Running net.sf.antcontrib.cpptasks.TestCCTask
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.009 sec
Running net.sf.antcontrib.cpptasks.TestCompilerDef
Class: CompilerDef and: CompilerDef
Tests run: 26, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 0.031 sec <<< FAILURE!
Running net.sf.antcontrib.cpptasks.TestTargetInfo
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.008 sec
Running net.sf.antcontrib.cpptasks.borland.TestBorlandCCompiler
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.01 sec
Running net.sf.antcontrib.cpptasks.trolltech.TestMetaObjectParser
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.019 sec
Running net.sf.antcontrib.cpptasks.devstudio.TestDevStudio2005CCompiler
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec
Running net.sf.antcontrib.cpptasks.TestLinkerEnum
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec
Running net.sf.antcontrib.cpptasks.compiler.TestCommandLineCompilerConfiguration
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.012 sec
Running net.sf.antcontrib.cpptasks.parser.TestCParser
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.01 sec
Running net.sf.antcontrib.cpptasks.compiler.TestLinkType
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec
Running net.sf.antcontrib.cpptasks.hp.TestaCCCompiler
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.009 sec
Running net.sf.antcontrib.cpptasks.types.TestDefineArgument
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.009 sec
Running net.sf.antcontrib.cpptasks.gcc.TestGccLinker
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 sec
Running net.sf.antcontrib.cpptasks.TestOutputTypeEnum
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec
Running net.sf.antcontrib.cpptasks.types.TestLibrarySet
Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.017 sec
Running net.sf.antcontrib.cpptasks.TestTargetHistoryTable$MockProcessorConfiguration
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec

Results :

Failed tests: 
  testExtendsCompilerArgs(net.sf.antcontrib.cpptasks.TestCompilerDef)
  testExtendsDefineSet(net.sf.antcontrib.cpptasks.TestCompilerDef)
  testExtendsIncludePath(net.sf.antcontrib.cpptasks.TestCompilerDef)
  testExtendsSysIncludePath(net.sf.antcontrib.cpptasks.TestCompilerDef)
  testExtendsDebug(net.sf.antcontrib.cpptasks.TestCompilerDef)
  testExtendsCompilerArgs(net.sf.antcontrib.cpptasks.TestCompilerDef)
  testExtendsDefineSet(net.sf.antcontrib.cpptasks.TestCompilerDef)
  testExtendsIncludePath(net.sf.antcontrib.cpptasks.TestCompilerDef)
  testExtendsSysIncludePath(net.sf.antcontrib.cpptasks.TestCompilerDef)
  testExtendsDebug(net.sf.antcontrib.cpptasks.TestCompilerDef)

Tests run: 437, Failures: 10, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18.150s
[INFO] Finished at: Fri Jun 14 00:02:11 CEST 2013
[INFO] Final Memory: 15M/221M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.6:test (default-test) on project cpptasks-parallel: There are test failures.
[ERROR] 
[ERROR] Please refer to D:\Downloads\Temp\maven-nar\cpptasks-parallel-master\cpptasks-parallel-master\target\surefire-reports for the individual test results.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

[lpouget-zz]

Exactly the same issue here. Tested with jdk6 and jdk7.

[dscho]

Sorry, I cannot reproduce. @lpouget, @S1lentSt0rm can you provide me with a bit more information, such as: what is the output in D:\Downloads\Temp\maven-nar\cpptasks-parallel-master\cpptasks-parallel-master\target\surefire-reports (and please do not blindly paste all and every file there, just the relevant parts that will help resolve this issue). I'd also be interested to know what Maven you use and how you call it. FWIW I tested it using an unpacked apache-maven-3.0.4, calling the mvn shell script with JAVA_HOME pointing to the Sun JDK 1.6.0_24 (and likewise JAVACMD) via the Git Bash.

File: TEST-net.sf.antcontrib.cpptasks.TestCompilerDef.xml

<testsuite failures="5" time="0.014" errors="0" skipped="0" tests="26" name="net.sf.antcontrib.cpptasks.TestCompilerDef">
  <properties>
...
    <property name="os.arch" value="amd64"/>
...
    <property name="os.name" value="Windows 7"/>
...
    <property name="java.home" value="C:\Program Files\Java\jdk1.7.0_17\jre"/> 
...
    <property name="java.version" value="1.7.0_17"/>
  </properties>
...
  <testcase time="0.001" classname="net.sf.antcontrib.cpptasks.TestCompilerDef" name="testExtendsCompilerArgs">
    <failure message="expected:&lt;3&gt; but was:&lt;4&gt;" type="junit.framework.AssertionFailedError">junit.framework.AssertionFailedError: expected:&lt;3&gt; but was:&lt;4&gt;
    at junit.framework.Assert.fail(Assert.java:47)
    at junit.framework.Assert.failNotEquals(Assert.java:280)
    at junit.framework.Assert.assertEquals(Assert.java:64)
    at junit.framework.Assert.assertEquals(Assert.java:198)
    at junit.framework.Assert.assertEquals(Assert.java:204)
    at net.sf.antcontrib.cpptasks.TestCompilerDef.testExtendsCompilerArgs(TestCompilerDef.java:229)
</failure>
  </testcase>
  <testcase time="0" classname="net.sf.antcontrib.cpptasks.TestCompilerDef" name="testExtendsDefineSet">
    <failure message="expected:&lt;3&gt; but was:&lt;4&gt;" type="junit.framework.AssertionFailedError">junit.framework.AssertionFailedError: expected:&lt;3&gt; but was:&lt;4&gt;
    at junit.framework.Assert.fail(Assert.java:47)
    at junit.framework.Assert.failNotEquals(Assert.java:280)
    at junit.framework.Assert.assertEquals(Assert.java:64)
    at junit.framework.Assert.assertEquals(Assert.java:198)
    at junit.framework.Assert.assertEquals(Assert.java:204)
    at net.sf.antcontrib.cpptasks.TestCompilerDef.testExtendsDefineSet(TestCompilerDef.java:249)
</failure>
  </testcase>
  <testcase time="0" classname="net.sf.antcontrib.cpptasks.TestCompilerDef" name="testExtendsIncludePath">
    <failure message="expected:&lt;3&gt; but was:&lt;4&gt;" type="junit.framework.AssertionFailedError">junit.framework.AssertionFailedError: expected:&lt;3&gt; but was:&lt;4&gt;
    at junit.framework.Assert.fail(Assert.java:47)
    at junit.framework.Assert.failNotEquals(Assert.java:280)
    at junit.framework.Assert.assertEquals(Assert.java:64)
    at junit.framework.Assert.assertEquals(Assert.java:198)
    at junit.framework.Assert.assertEquals(Assert.java:204)
    at net.sf.antcontrib.cpptasks.TestCompilerDef.testExtendsIncludePath(TestCompilerDef.java:266)
</failure>
  </testcase>
  <testcase time="0.001" classname="net.sf.antcontrib.cpptasks.TestCompilerDef" name="testExtendsSysIncludePath">
    <failure message="expected:&lt;3&gt; but was:&lt;4&gt;" type="junit.framework.AssertionFailedError">junit.framework.AssertionFailedError: expected:&lt;3&gt; but was:&lt;4&gt;
    at junit.framework.Assert.fail(Assert.java:47)
    at junit.framework.Assert.failNotEquals(Assert.java:280)
    at junit.framework.Assert.assertEquals(Assert.java:64)
    at junit.framework.Assert.assertEquals(Assert.java:198)
    at junit.framework.Assert.assertEquals(Assert.java:204)
    at net.sf.antcontrib.cpptasks.TestCompilerDef.testExtendsSysIncludePath(TestCompilerDef.java:284)
</failure>
    <system-out>Class: CompilerDef and: CompilerDef
</system-out>
  </testcase>
...
  <testcase time="0" classname="net.sf.antcontrib.cpptasks.TestCompilerDef" name="testExtendsDebug">
    <failure message="expected:&lt;-[g]&gt; but was:&lt;-[mwindows]&gt;" type="junit.framework.ComparisonFailure">junit.framework.ComparisonFailure: expected:&lt;-[g]&gt; but was:&lt;-[mwindows]&gt;
    at junit.framework.Assert.assertEquals(Assert.java:81)
    at junit.framework.Assert.assertEquals(Assert.java:87)
    at net.sf.antcontrib.cpptasks.TestProcessorDef.testExtendsDebug(TestProcessorDef.java:261)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:601)
    at junit.framework.TestCase.runTest(TestCase.java:164)
    at junit.framework.TestCase.runBare(TestCase.java:130)
    at junit.framework.TestResult$1.protect(TestResult.java:106)
    at junit.framework.TestResult.runProtected(TestResult.java:124)
    at junit.framework.TestResult.run(TestResult.java:109)
    at junit.framework.TestCase.run(TestCase.java:120)
    at junit.framework.TestSuite.runTest(TestSuite.java:230)
    at junit.framework.TestSuite.run(TestSuite.java:225)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:601)
    at org.apache.maven.surefire.junit.JUnitTestSet.execute(JUnitTestSet.java:213)
    at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:120)
    at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:103)
    at org.apache.maven.surefire.Surefire.run(Surefire.java:169)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:601)
    at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:350)
    at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1021)
</failure>
  </testcase>
</testsuite>

Output of mvn --version:

Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19 14:51:28+0100)
Maven home: C:\Program Files\apache-maven-3.0.5\bin\..
Java version: 1.7.0_17, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.7.0_17\jre
Default locale: de_DE, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"

I just do: maven install

[dscho]

Aaaah, the crucial part, of course, is:

<failure message="expected:<-[g]> but was:<-[mwindows]>" type="junit.framework.ComparisonFailure">junit.framework.ComparisonFailure: expected:<-[g]> but was:<-[mwindows]>
...

So the information that is still missing: what is your C/C++ compiler? It looks like you have a MinGW compiler. And sure enough, if I try to build it with the Git for Windows SDK (called ''msysGit''), I can reproduce your test failure. Before that, the nar plugin obviously picked Visual Studio over GNU C (because it did not know where to look for GNU C, but it knew where to look for Visual Studio).

Indeed I use MinGW:

gcc (rev1, Built by MinGW-builds project) 4.8.1
Copyright (C) 2013 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

So how can I solve the problem?

[dscho]

Yep, the problem seems to be exactly that. Already the first failure (expected:<3> but was:<4>) is triggered by using a MinGW compiler. It uses the options ''/base, -c, -mwindows, -fno-exceptions'' instead of the expected ''/base, -c, -fno-exceptions''.

I fear that the proper solution is to fix those tests to be more lenient toward special architectures requiring an extra, say, ''-mwindows'' flag. Something like a containsMFlag(String[] args) that returns 1 (or the index of the ''-m'' flag) and is used in the unit test to expect the proper number of arguments.

[dscho]

Or even better: the getPreArguments method could filter out ''-m*'' options... Something like

protected String[] getPreArguments(final ProcessorDef processor) {
    final String[] result = ((CommandLineCompilerConfiguration) getConfiguration(processor))
        .getPreArguments();

    // filter out -m (i.e. platform-specific) options
    int j = -1;
    for (int i = 0; i < result.length; i++) {
        if (result[i].startsWith("-m")) continue;
        if (i != ++j) result[j] = result[i];
    }
    if (++j == result.length) return result;
    final String[] filtered = new String[j];
    System.arraycopy(result, 0, filtered, 0, j);
    return filtered;
}

Not the nicest code, but a start.

[dscho]

@S1lentSt0rm can you have a look at the pull request?

I saw it, thank you!
I think I can close this Issue then...

[dscho]

@ghost well, you should still review the pull request because I will not merge it without having had at least another pair of eyes looking over it.