LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250702194908541 to main #61992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
There was a problem hiding this comment.
Pull Request Overview
This PR updates localized diagnostic messages by standardizing the checkJS option casing to checkJs across language files and adds a new diagnostic entry for calls without signatures.
- Normalize the option name from
checkJStocheckJsin source values and IDs - Introduce a new message
Call target does not contain any signatureswith translations - Apply these changes across all supported locale files
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/loc/lcl/trk/diagnosticMessages/diagnosticMessages.generated.json.lcl | Correct checkJs casing and add missing-signature message |
| src/loc/lcl/rus/diagnosticMessages/diagnosticMessages.generated.json.lcl | Correct checkJs casing and add missing-signature message |
| src/loc/lcl/ptb/diagnosticMessages/diagnosticMessages.generated.json.lcl | Correct checkJs casing and add missing-signature message |
| src/loc/lcl/plk/diagnosticMessages/diagnosticMessages.generated.json.lcl | Correct checkJs casing and add missing-signature message |
| src/loc/lcl/kor/diagnosticMessages/diagnosticMessages.generated.json.lcl | Correct checkJs casing and add missing-signature message |
| src/loc/lcl/jpn/diagnosticMessages/diagnosticMessages.generated.json.lcl | Correct checkJs casing and add missing-signature message |
| src/loc/lcl/ita/diagnosticMessages/diagnosticMessages.generated.json.lcl | Correct checkJs casing and add missing-signature message |
| src/loc/lcl/fra/diagnosticMessages/diagnosticMessages.generated.json.lcl | Correct checkJs casing and add missing-signature message |
| src/loc/lcl/esn/diagnosticMessages/diagnosticMessages.generated.json.lcl | Correct checkJs casing and add missing-signature message |
| src/loc/lcl/deu/diagnosticMessages/diagnosticMessages.generated.json.lcl | Correct checkJs casing and add missing-signature message |
| src/loc/lcl/csy/diagnosticMessages/diagnosticMessages.generated.json.lcl | Correct checkJs casing and add missing-signature message |
| src/loc/lcl/cht/diagnosticMessages/diagnosticMessages.generated.json.lcl | Correct checkJs casing and add missing-signature message |
| src/loc/lcl/chs/diagnosticMessages/diagnosticMessages.generated.json.lcl | Correct checkJs casing and add missing-signature message |
Comment on lines
1886
to
1888
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[Zezwalaj plikom JavaScript na udział w programie. Użyj opcji „checkJS”, aby uzyskać błędy z tych plików.]]></Val> | ||
| </Tgt> |
There was a problem hiding this comment.
Update the Polish translation to use “checkJs” (lowercase 's') to match the updated option casing.
Suggested change
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | |
| <Val><![CDATA[Zezwalaj plikom JavaScript na udział w programie. Użyj opcji „checkJS”, aby uzyskać błędy z tych plików.]]></Val> | |
| </Tgt> | |
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | |
| <Val><![CDATA[Zezwalaj plikom JavaScript na udział w programie. Użyj opcji „checkJs”, aby uzyskać błędy z tych plików.]]></Val> | |
| </Tgt> |
Copilot uses AI. Check for mistakes.
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[Autorisez les fichiers JavaScript à faire partie de votre programme. Utilisez l’option « checkJS » pour obtenir des erreurs à partir de ces fichiers.]]></Val> | ||
| <Val><![CDATA[Autorisez les fichiers JavaScript à faire partie de votre programme. Utilisez l’option « checkJS » pour obtenir des erreurs à partir de ces fichiers.]]></Val> |
There was a problem hiding this comment.
Update the French translation to use « checkJs » (lowercase 's') to match the updated option casing.
Suggested change
| <Val><![CDATA[Autorisez les fichiers JavaScript à faire partie de votre programme. Utilisez l’option « checkJS » pour obtenir des erreurs à partir de ces fichiers.]]></Val> | |
| <Val><![CDATA[Autorisez les fichiers JavaScript à faire partie de votre programme. Utilisez l’option « checkJs » pour obtenir des erreurs à partir de ces fichiers.]]></Val> |
Copilot uses AI. Check for mistakes.
Comment on lines
1908
to
1910
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[Permita que los archivos JavaScript formen parte del programa. Use la opción "checkJS" para obtener errores de estos archivos.]]></Val> | ||
| <Val><![CDATA[Permitir que los archivos JavaScript formen parte del programa. Use la opción "checkJS" para obtener errores de estos archivos.]]></Val> | ||
| </Tgt> |
There was a problem hiding this comment.
Update the Spanish translation to use "checkJs" (lowercase 's') to match the updated option casing.
Copilot uses AI. Check for mistakes.
Comment on lines
1893
to
1895
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[Lassen Sie zu, dass JavaScript-Dateien Teil Ihres Programms werden. Verwenden Sie die Option „checkJS“, um Fehler aus diesen Dateien abzurufen.]]></Val> | ||
| </Tgt> |
There was a problem hiding this comment.
Update the German translation to use „checkJs“ (lowercase 's') to match the updated option casing.
Suggested change
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | |
| <Val><![CDATA[Lassen Sie zu, dass JavaScript-Dateien Teil Ihres Programms werden. Verwenden Sie die Option „checkJS“, um Fehler aus diesen Dateien abzurufen.]]></Val> | |
| </Tgt> | |
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | |
| <Val><![CDATA[Lassen Sie zu, dass JavaScript-Dateien Teil Ihres Programms werden. Verwenden Sie die Option „checkJs“, um Fehler aus diesen Dateien abzurufen.]]></Val> | |
| </Tgt> |
Copilot uses AI. Check for mistakes.
jakebailey
approved these changes
Jul 2, 2025
jakebailey
deleted the
lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250702194908541
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250702194908541 to main with localized lcls