-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Add reflection pattern to agbench lint
#6051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gagb
wants to merge
20
commits into
main
Choose a base branch
from
gagb/qualcoder
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verity-based output formatting
…n; implement log summary generation in CLI
@changliu2 and @ShipraJain01 fyi |
afourney
approved these changes
Mar 21, 2025
Generally looks good, but it's failing the CI. |
Working with @jackgerrits to resolve it. Not sure what's causing all the uv errors. |
More features to add based on Chang's feedback
|
@jackgerrits , I changed my uv to 0.5.18 but I am still stuck in uv.lock rabbit hole. Help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
agbench
package, focusing on adding new functionality, improving existing code, and updating dependencies. The most important changes include adding a new dependency, modifying theDocument
class, enhancing thecode_document
method, and introducing a new prompt for qualitative coding.Dependency Updates:
tiktoken
library to the dependencies inpyproject.toml
.Enhancements to Document Class:
lines
field to theDocument
class to store the document as a list of strings.load_log_file
function to populate thelines
field in theDocument
class.Improvements to Qualitative Coding:
MAIN_PROMPT
for generating error codes inoai_coder.py
.count_tokens
function to count tokens using thetiktoken
library.code_document
method to handle long documents, generate feedback, and update codes based on feedback. [1] [2] [3]These changes aim to improve the accuracy and efficiency of the qualitative coding process in the
agbench
package.