Skip to content

[Experimental] HTTP agent runtime #6356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

lspinheiro
Copy link
Collaborator

Why are these changes needed?

This is an initial proposal for an experimental http agent runtime based on fastapi and json-rpc. The goal is to support existing middleware system to facilitate enhancement of agent functionality such as enabling authentication.

Related issue number

Related to #6355

Checks

@lspinheiro lspinheiro requested review from jackgerrits and ekzhu April 22, 2025 02:58
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

Attention: Patch coverage is 61.65884% with 245 lines in your changes missing coverage. Please review.

Project coverage is 78.85%. Comparing base (cc2693b) to head (8ab2a22).

Files with missing lines Patch % Lines
...t/src/autogen_ext/runtimes/http/_worker_runtime.py 63.55% 129 Missing ⚠️
...ext/runtimes/http/_worker_runtime_host_servicer.py 53.50% 73 Missing ⚠️
.../autogen_ext/runtimes/http/_worker_runtime_host.py 60.90% 43 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6356      +/-   ##
==========================================
- Coverage   79.52%   78.85%   -0.67%     
==========================================
  Files         225      230       +5     
  Lines       16641    17280     +639     
==========================================
+ Hits        13233    13627     +394     
- Misses       3408     3653     +245     
Flag Coverage Δ
unittests 78.85% <61.65%> (-0.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@yogitasrivastava yogitasrivastava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Content-type
    Consider enforcing a stricter Content‑Type: application/json on incoming requests early, with clear 415/400 responses for bad payloads.

  2. Runtime vs. Host separation
    The split between HttpWorkerAgentRuntime and HttpWorkerAgentRuntimeHost is clean, but the naming feels a bit opaque (the “HostServicer” suffix sounds gRPC‑ish). Kindly consider renaming the host side to something like HttpAgentServer or HttpAgentHost for clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants