Skip to content

Add AutomationProperties.Name to Process Selection DataGrid for accessibility #2239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jun 13, 2025

Fixes an accessibility issue where the DataGrid in the "Select Process Window" popup lacked a proper name for screen readers and assistive technologies.

Problem

When using accessibility tools like "Accessibility Insights for Windows" on the Select Process dialog, the DataGrid element showed as datagrid '' with an empty name, violating the accessibility requirement that "The Name property of a focusable element must not be null."

Solution

Added AutomationProperties.Name="Process selection table" to the DataGrid element in SelectProcess.xaml. This provides a meaningful, descriptive name for screen readers and follows the established pattern used throughout the PerfView codebase for similar controls.

Changes

  • Minimal change: Added one line to /src/PerfView/Dialogs/SelectProcess.xaml
  • Consistent naming: Follows existing patterns like "Events Table", "Multi-Line View", etc.
  • No functional impact: Only improves accessibility, no behavior changes

Testing

  • Verified XAML is well-formed
  • Confirmed change follows established codebase patterns
  • Minimal scope: only 1 file modified with 1 line addition

Fixes #2238.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…sibility

Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] The Name property of a focusable element must not be null Add AutomationProperties.Name to Process Selection DataGrid for accessibility Jun 13, 2025
@Copilot Copilot AI requested a review from brianrob June 13, 2025 18:25
Copilot finished work on behalf of brianrob June 13, 2025 18:25
@brianrob brianrob marked this pull request as ready for review June 13, 2025 21:13
@brianrob
Copy link
Member

Co-pilot Post-Mortem:

  • The code was easy for copilot to get right.
  • I appreciated that the PR description described the solution and called out that this was done elsewhere for comparison, such that I was able to build reasonable confidence in the fix rather quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Name property of a focusable element must not be null
2 participants