Skip to content

Remove documentation website files #7915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 18, 2025
Merged

Conversation

ADubhlaoich
Copy link
Contributor

Proposed changes

This commit removes the documentation website files, which have been migrated to the main documentation repository. It also includes some changes to configuration files that are redundant, such as removing the deployment action from the repository.

Some configuration changes have been left in place for context, and there will likely be some future follow up work to re-integrate certain automations as part of enhancements to the documentation repository.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

This commit removes the documentation website files, which have been
migrated to the main documentation repository. It also includes some
changes to configuration files that are redundant, such as removing
the deployment action from the repository.

Some configuration changes have been left in place for context, and
there will likely be some future follow up work to re-integrate certain
automations as part of enhancements to the documentation repository.
@ADubhlaoich ADubhlaoich requested review from a team as code owners June 18, 2025 10:17
@github-actions github-actions bot added documentation Pull requests/issues for documentation github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Jun 18, 2025
vepatel
vepatel previously approved these changes Jun 18, 2025
AlexFenlon
AlexFenlon previously approved these changes Jun 18, 2025
@vepatel
Copy link
Contributor

vepatel commented Jun 18, 2025

egrep -v "^site/" can be removed from https://github.com/nginx/kubernetes-ingress/blob/docs/remove-website-files/.github/workflows/ci.yml#L62

Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.82%. Comparing base (71639ef) to head (6d99e6a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7915      +/-   ##
==========================================
+ Coverage   52.67%   52.82%   +0.15%     
==========================================
  Files          90       90              
  Lines       21598    21671      +73     
==========================================
+ Hits        11376    11447      +71     
- Misses       9745     9747       +2     
  Partials      477      477              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

javorszky
javorszky previously approved these changes Jun 18, 2025
@ADubhlaoich
Copy link
Contributor Author

@vepatel Incorporating the feedback now.

I'm not brave enough to touch the release automation files, hahaha.

@ADubhlaoich ADubhlaoich dismissed stale reviews from javorszky and AlexFenlon via b29be0f June 18, 2025 11:35
@github-actions github-actions bot removed the chore Pull requests for routine tasks label Jun 18, 2025
@ADubhlaoich ADubhlaoich force-pushed the docs/remove-website-files branch from 10ea08c to 40ecc72 Compare June 18, 2025 11:47
@ADubhlaoich ADubhlaoich enabled auto-merge (squash) June 18, 2025 14:53
@ADubhlaoich ADubhlaoich merged commit 5f037b9 into main Jun 18, 2025
82 checks passed
@ADubhlaoich ADubhlaoich deleted the docs/remove-website-files branch June 18, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants