Skip to content

Add support for Agent V3 and Connecting to NGINX One Console #7916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 81 commits into
base: main
Choose a base branch
from

Conversation

AlexFenlon
Copy link
Contributor

Proposed changes

  • Pin Agent V3 images to V3.0.2
  • Allow users to connect ot NGINX One Console via Helm or Manifest
  • Update NGINX Agent Helm values to allow V3
  • Allow Users to use a Kubernetes Secret to update their DataplaneKey
  • Add missing makefile UBI8 command
  • Cleaned up Dockerfile due to the removal of the Agent Arg as Agent is always installed in images that are not WAF at the moment.

Docs updates coming soon™

At the moment, here is the extensive list of images with specific Agent versions. Agent V3 does not currently have NGINX App Protect support so once that is available, all images will use the latest V3 in the future.

AGENT V3:

  • Debian OSS (debian-image)
  • Debian PLUS (debian-image-plus)
  • Alpine OSS (alpine-image)
  • Alpine PLUS (alpine-image-plus)
  • Alpine PLUS + FIPS (alpine-image-plus-fips)
  • UBI 9 OSS (ubi-image)
  • UBI 9 PLUS (ubi-image-plus)

AGENT V2:

  • Debian NAP WAF v4 (debian-image-nap-plus)
  • Debian NAP WAF v4 + DOS (debian-image-nap-dos-plus)
  • Debian NAP WAF v5 (debian-image-nap-v5-plus)
  • Alpine NAP WAF v4 + FIPS (alpine-image-nap-plus-fips)
  • Alpine NAP WAF v5 + FIPS (alpine-image-nap-v5-plus-fips)
  • UBI 9 NAP WAF v4 (ubi-image-nap-plus)
  • UBI 9 NAP WAF v4 + DOS (ubi-image-nap-dos-plus)
  • UBI 9 NAP WAF v5 (ubi-image-nap-v5-plus)
  • UBI 8 NAP WAF v4 (ubi8-image-nap-plus)
  • UBI 8 NAP WAF v5 (ubi8-image-nap-v5-plus)

NO AGENT:

  • Debian DOS (debian-image-dos-plus)
  • UBI DOS (ubi-image-dos-plus)

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested a review from a team as a code owner June 18, 2025 11:37
@github-actions github-actions bot added go Pull requests that update Go code python Pull requests that update Python code github_actions Pull requests that update Github_actions code docker Pull requests that update Docker code chore Pull requests for routine tasks tests Pull requests that update tests helm_chart Pull requests that update the Helm Chart labels Jun 18, 2025
@AlexFenlon AlexFenlon linked an issue Jun 18, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.82%. Comparing base (71639ef) to head (524ee7f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7916      +/-   ##
==========================================
+ Coverage   52.67%   52.82%   +0.15%     
==========================================
  Files          90       90              
  Lines       21598    21668      +70     
==========================================
+ Hits        11376    11447      +71     
+ Misses       9745     9744       -1     
  Partials      477      477              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks docker Pull requests that update Docker code github_actions Pull requests that update Github_actions code go Pull requests that update Go code helm_chart Pull requests that update the Helm Chart python Pull requests that update Python code tests Pull requests that update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose a Secure Agent Secret
5 participants