-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Add three new examples #1414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add three new examples #1414
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going AFK for a few minutes but will return to finish this review soon 👍
config: | ||
url: https://service.internal | ||
on_error: continue | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this blank line intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I often find it easier to "see" the policy when there's a bit of whitespace between the blocks. It doesn't affect how the policy runs, just a personal choice. Happy to remove it if we want consistency in not having whitespace!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful 👍 Left some suggestions, but approving so you can merge when you handle them
docs/universal-gateway/examples/secure-developer-environments.mdx
Outdated
Show resolved
Hide resolved
docs/universal-gateway/examples/secure-developer-environments.mdx
Outdated
Show resolved
Hide resolved
docs/universal-gateway/examples/secure-developer-environments.mdx
Outdated
Show resolved
Hide resolved
docs/universal-gateway/examples/secure-developer-environments.mdx
Outdated
Show resolved
Hide resolved
docs/universal-gateway/examples/secure-developer-environments.mdx
Outdated
Show resolved
Hide resolved
Brilliant, thank you @S3Prototype! Left one explanation, which we can always clean up later. I'll merge once CI finishes up. |
Time to keep pushing!