Skip to content

Add three new examples #1414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 20, 2025
Merged

Add three new examples #1414

merged 5 commits into from
Jun 20, 2025

Conversation

joelhans
Copy link
Contributor

Time to keep pushing!

  • Deploy Custom Error Pages
  • Route to Services Based on OIDC Authentication
  • Create Secure Public Developer Environments

Copy link

vercel bot commented Jun 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ngrok-docs ✅ Ready (Inspect) Visit Preview Jun 20, 2025 4:51pm

Copy link
Collaborator

@S3Prototype S3Prototype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going AFK for a few minutes but will return to finish this review soon 👍

config:
url: https://service.internal
on_error: continue

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this blank line intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I often find it easier to "see" the policy when there's a bit of whitespace between the blocks. It doesn't affect how the policy runs, just a personal choice. Happy to remove it if we want consistency in not having whitespace!

Copy link
Collaborator

@S3Prototype S3Prototype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 👍 Left some suggestions, but approving so you can merge when you handle them

@joelhans
Copy link
Contributor Author

joelhans commented Jun 20, 2025

Brilliant, thank you @S3Prototype! Left one explanation, which we can always clean up later. I'll merge once CI finishes up.

@joelhans joelhans merged commit 388b43f into main Jun 20, 2025
3 checks passed
@joelhans joelhans deleted the joelhans/examples-2 branch June 20, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants