Skip to content

Update Agent TLS Termination guides #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 7, 2025
Merged

Update Agent TLS Termination guides #1449

merged 11 commits into from
Jul 7, 2025

Conversation

S3Prototype
Copy link
Collaborator

@S3Prototype S3Prototype commented Jul 2, 2025 •
edited
Loading

  • We have multiple TLS guides with exactly the same content
    • This PR deletes the ones in the less useful places, and redirects them to the better ones
  • It also breaks the TLS termination guide into two separate pages. One for TLS and one for mTLS

Previews:

@S3Prototype
Update Agent TLS Termination guides
7f231c5 
- We have two guides with exactly the same content
  - This PR deletes the one in the less useful place, and redirects it to the better one
- wip
@vercel Vercel
Copy link

vercel bot commented Jul 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ngrok-docs ✅ Ready (Inspect) Visit Preview Jul 7, 2025 2:54pm

@sg-writer sg-writer added docs/content Changes to the written material in the docs area/tunnels labels Jul 2, 2025
@S3Prototype S3Prototype requested a review from sg-writer July 2, 2025 19:55
@S3Prototype S3Prototype marked this pull request as ready for review July 2, 2025 19:55
sg-writer
sg-writer reviewed Jul 2, 2025
View reviewed changes
docs/agent/agent-mutual-tls-termination.mdx Outdated

```bash
ngrok http 8080 --url terminate-tls-example.ngrok.app --traffic-policy-file /path/to/policy.yml
ngrok http 8080 --url your-reserved-domain-here --traffic-policy-file /path/to/policy.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: reserved domain placeholder text comes up often enough that I think we should standardize it across the board. What about something like $YOUR_DOMAIN or $YOUR_RESERVED_DOMAIN? Personally I like big ugly placeholders because they're hard to miss as a reader.

sg-writer
sg-writer approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@sg-writer sg-writer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one nitpick comment for consideration but nothing blocking

@S3Prototype S3Prototype enabled auto-merge (squash) July 7, 2025 14:50
@S3Prototype S3Prototype merged commit d1ef5d7 into main Jul 7, 2025
3 checks passed
@S3Prototype S3Prototype deleted the shaquil/doc-309-agent-tls-termination branch July 7, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sg-writer sg-writer sg-writer approved these changes

Assignees
No one assigned
Labels
area/tunnels docs/content Changes to the written material in the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@S3Prototype @sg-writer