feat: suppress internal spans with Faraday instrumentation #1506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezhang6811
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle,
xuan-cao-swi and
a team
as code owners
...mentation/faraday/lib/opentelemetry/instrumentation/faraday/middlewares/tracer_middleware.rb
Show resolved
Hide resolved
instrumentation/faraday/lib/opentelemetry/instrumentation/faraday/instrumentation.rb
Show resolved
Hide resolved
instrumentation/faraday/README.md
Outdated
| @@ -19,6 +19,7 @@ To install the instrumentation, call `use` with the name of the instrumentation. | |||
| ```ruby | |||
| OpenTelemetry::SDK.configure do |c| | |||
| c.use 'OpenTelemetry::Instrumentation::Faraday' | |||
| suppress_internal_instrumentation: true | |||
There was a problem hiding this comment.
arielvalentin
approved these changes
May 30, 2025
arielvalentin
approved these changes
May 30, 2025
instrumentation/faraday/README.md
Outdated
Comment on lines
21
to
22
| c.use 'OpenTelemetry::Instrumentation::Faraday' | ||
| enable_internal_instrumentation: false |
There was a problem hiding this comment.
Just noticed that this example is incorrect. The options need to be a parameter to use so there should be a comma here.
There was a problem hiding this comment.
Fixed, thanks for catching that
|
@ezhang6811 if the tests all pass I will merge and you should expect a Release this Tuesday 2025-06-03 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1502 for Faraday library instrumentation. Allow user to set
suppress_internal_instrumentationflag when configuring Faraday instrumentation to suppress additional client spans generated from underlying Net::Http instrumentation.Before merging, waiting for update on Github issue to see if internal span suppression can be made default behavior for both Faraday and AWS SDK.