feat: AWS X-Ray Remote Sampler Part 3 - Add Rate Limiter and Sampling Targets Poller Logic #1536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the 3rd and final PR to address #1434 in order for OTel Ruby to support X-Ray Remote Sampling.
Changes:
sampling_rule_applier
.sampling_rule_applier
will sample the requests.GetSamplingTargets
call to determine the next targetrate_limiting_sampler
(applied before the fixed rate sampler) to be used in each rule applier.fallback_sampler
is updated to be a combination of above samplers to sample1 req/sec
and5%
of additional requests in that second.example/xray_sampling_on_rails_demonstration.ru
that runs an example rails application that uses the OpenTelemetry X-Ray Sampler, with example instructions in the comments at the bottom of the file.Testing