feat: NET::HTTP semantic convention stability migration #1572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahramadan
commented
Jun 24, 2025
...mentation/net_http/lib/opentelemetry/instrumentation/net/http/patches/dup/instrumentation.rb
Outdated
Show resolved
Hide resolved
hannahramadan
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle,
xuan-cao-swi and
a team
as code owners
9 tasks
Comment on lines
+76
to
+82
| if use_ssl? && proxy? | ||
| span_name = 'CONNECT' | ||
| span_kind = :client | ||
| else | ||
| span_name = 'connect' | ||
| span_kind = :internal | ||
| end |
There was a problem hiding this comment.
Same question here as on Excon: why is connect capitalized in one case and lowercase in the other?
There was a problem hiding this comment.
I'm not sure, but it seems to be intentional. I'll see if I can dig up anything on this. Also discussed in #1569 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to assist in the transition from the old to new HTTP semantic conventions. Per the HTTP semantic convention stability migration spec, users should be able to set the environment variable
OTEL_SEMCONV_STABILITY_OPT_INto:httpto emit stable conventions onlyhttp/dupto emit both old and the stable conventionsHTTP GETis now justGET- specSpecial note about NET::HTTP changes:
http.targetis split into two separate attributes,url.pathandurl.query, under stable conventions. Unlike some other HTTP libraries, NET::HTTP reports these attributes as one path. Because of this, some additional work was done to to separate the path from the query in order to report them as separate attributes.The agent is required to maintain this bridge for 6 months and may drop the environment variable in the next major version and emit only the stable HTTP and networking conventions.
This approach was approved in #1547