Skip to content

Conversation

JiriCtvrtka
Copy link

PR to try remove vendor folder and use modules.

@it-percona-cla
Copy link

it-percona-cla commented Apr 15, 2025

CLA assistant check
All committers have signed the CLA.

@JiriCtvrtka JiriCtvrtka changed the base branch from main to dev April 15, 2025 08:32
@radoslawszulgo radoslawszulgo requested a review from Copilot August 26, 2025 11:37
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the vendor directory approach and migrates to using Go modules for dependency management. The change modernizes the build process by leveraging Go's module system instead of vendoring dependencies.

  • Updated Go version from 1.22 to 1.23.0 with toolchain 1.23.4
  • Changed build flags from -mod=vendor to -mod=mod in Makefile
  • Removed vendor directory exclusions from GitHub workflow files
  • Updated various golang.org/x dependencies to newer versions

Reviewed Changes

Copilot reviewed 3 out of 4188 changed files in this pull request and generated no comments.

File Description
go.mod Updates Go version and dependency versions to support module-based builds
Makefile Changes build flags to use module mode instead of vendor mode
.github/workflows/reviewdog.yml Removes vendor directory exclusions from linting workflows

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@radoslawszulgo radoslawszulgo self-requested a review August 26, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants