-
Notifications
You must be signed in to change notification settings - Fork 96
PBM-1511: Configuration for Fallback dbpath feature #1139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+603
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... --allow-partly-done options
It takes into accoount: - cluster status, - node status, - fallback-enabled opt - allow-partly-done opt
... and warn user in logs
... allow-partly-done
It'll include base + all increments sizes on RS when calculationg available disk space for fallbacksync feature.
... during physical restore
veceraj
previously approved these changes
Jun 9, 2025
veceraj
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for https://perconadev.atlassian.net/browse/PBM-1511
Following options and config params are added for
pbm restore
command:fallbackEnabled config param:
Enables or disables
fallback
feature during physical restore. Whenfallback
is enabled, PBM moves all data files to the.fallbacksync
dir, and if an error occurs during restore, PBM rolls back the whole cluster to the state before the restore.allowPartlyDone config param:
If enabled, apply
fallback
feature topartly-done
cluster. If the cluster finishes the restore with a state ofpartly-done
, this parameter allows to decide whether to apply thefallback
feature or not to such a cluster (successfully restored). When this parameter is disabled, PBM appliesfallback
feature and rolls back the whole cluster to the state before the restore.Command line options for
restore
commandDisk free space validation
Before applying restore with enabled
fallback
feature,pbm-agents
check for available space on disk and logs:In case when there's not enough space restore will be canceled.
In case of incremental backup, all increments will be included in the backup size calculation.
Backup size metrics reported with
describe-backup
commandFollowing additional metrics are reported:
Support for older backups (v2.9.1 and below)
When
fallback
feature is enabled, and backup is made with PBM v2.9.1 or older release,fallback
feature cannot be applied due to missing information about backup sizes on RS level. For such a backup,fallback
feature will be automatically disabled and PBM will add log entry with appropriate description.