Use systemd-networkd-wait-online --any by default
#193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are about to have subdirectories in configs/os/services/, so use `cp` instead of `install` to copy everything wholesale.
This way, systemd-networkd-wait-online won't hang on boot for users who only have _some_ of the configured interfaces online / in use (which is the case for everyone who sets up Wi-Fi, since kvmd-bootconfig does not remove eth0.network even if it was never intended to be used). We deem this networking semantics typical for Pi-KVM in general; users who need to wait for multiple interfaces to activate will have to countermand this drop-in manually. Fixes pikvm/pikvm#1514.
intelfx
force-pushed
the
work/fix-1514-networkd-wait-online
branch
from
92e4824 to
4bb6579
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that
systemd-networkd-wait-online(which is used when e.g. mounting remote filesystems via fstab) will only wait for the first (networkd-managed) interface to come up, not all of them. This properly ignores any networkd-unmanaged interfaces such as lo, tailscale0, WWAN modems or dynamically created otgnet ones.This way, systemd-networkd-wait-online won't hang on boot for users who only have some of the configured interfaces online/in use (which is the case for everyone who sets up Wi-Fi, since kvmd-bootconfig does not remove
eth0.networkeven if it was never intended to be used).We deem this semantics typical for Pi-KVM in general, thus the configuration override will be shipped as part of kvmd package. Users who do need to wait for all interfaces to activate will have to countermand this drop-in manually.
Fixes pikvm/pikvm#1514.