Skip to content

Add Hindi translation for UI strings on the About page #3526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

Subham-KRLX
Copy link

Fixes #3485

This pull request introduces a comprehensive Hindi translation for the user interface strings present on the "About" page of the p5.js Web Editor. The changes encompass:

Translation of all static text elements on the About page.

Updates to the hi.json locale file to include the new translations.

Ensuring consistency with existing translation guidelines and formatting.

Copy link

welcome bot commented Jun 17, 2025

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

Copy link
Contributor

@yugalkaushik yugalkaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly make sure to run the ESLint check before creating a PR. Also, several changes in your commit appear to be unnecessary. Please review your changes carefully before raising a pull request.

@Subham-KRLX
Copy link
Author

Thank you for the review, @yugalkaushik 🙏
I’ve addressed your feedback:

✅ Re‑ran npm run lint locally and fixed all lint errors.

✅ Removed unrelated or out‑of‑scope changes.

✅ Ran npm test: 25 test suites passed, 150 tests passed.

✅ Squashed commits for a clean history.
Could you please take another look when you have a moment? Thanks!

@Subham-KRLX Subham-KRLX requested a review from yugalkaushik June 18, 2025 02:58
Copy link
Contributor

@yugalkaushik yugalkaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. You don't need to commit the package-lock.json file, please exclude it from the PR.
  2. You've updated the bengali translation instead of hindi, and in the process, removed several important text entries.
  3. The changes made in index.js are unnecessary and have also removed some crucial comments.

Please take some time to go through the contribution and translation guidelines carefully. At the moment, this PR is unclear and doesn’t align with the issue's requirements.

@Subham-KRLX
Copy link
Author

Subham-KRLX commented Jun 18, 2025

Hi @yugalkaushik,
Thank you very much for your valuable feedback!
I have now removed the package-lock.json file from the PR, reverted the unintended changes to the Bengali translation, and restored the unnecessary changes in index.js.

The PR now contains only the intended Hindi translation updates as per the contribution guidelines.
Please let me know if anything else needs improvement. I appreciate your time and help!

@yugalkaushik
Copy link
Contributor

So what exactly are you trying to do here change the labels of About page or do hindi translation because I can't see any translation files and the package-lock.json file is still there.

@Subham-KRLX Subham-KRLX requested a review from yugalkaushik June 19, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some text on the p5.js Editor “About” page is not translated
2 participants