Add aria-labels and accessibility improvements to buttons and navigation... #894
+32
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ksen0 I have reviewed this PR, and it looks good. |
ksen0
reviewed
Jul 16, 2025
There was a problem hiding this comment.
Hi @eslteacher902010 thank you for working on this! Happy to merge - just a very small request about the indentation.
src/components/Nav/JumpToLinks.tsx
Outdated
| <Icon kind={isOpen ? "chevron-down" : "chevron-up"} /> | ||
| </div> | ||
| </button> | ||
| class={styles.toggle} |
There was a problem hiding this comment.
Could you fix the indentation here, please? Looks like some spaces got dropped
src/components/Nav/MainNavLinks.tsx
Outdated
| aria-hidden="true" | ||
| tabIndex={-1} | ||
| > | ||
| class={styles.toggle} |
There was a problem hiding this comment.
Same spacing issue here- thank you!
There was a problem hiding this comment.
I tried to fix it, but let me know if I'm off in any way. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some aria labels. Some of the aria labels also add language filtering components. I hope this works.
I'm new to this, so appreciate your patience. Thanks!
Addresses #874