You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey @ksen0, I’ve added p5.Graphics.prototype.splineVertex in my PR to address the missing method error — it now proxies to this._renderer.splineVertex(...). After adding it, the test passes successfully (AssertionError: expected undefined to be truthy is gone).
However, I’m unsure if the placement of this extension is ideal. Currently, I’ve placed it src/core/p5.Graphics.js, but it might make more sense to move it somewhere more appropriate in the codebase.
Would love your guidance on where this kind of prototype patch is best placed structurally. Or my pr need Changes
Most appropriate sub-area of p5.js?
p5.js version
2.0.0
Web browser and version
Firefox 137.0.2 / archlinux
Operating system
Arch Linux 2024-04-18
Steps to reproduce this
Steps:
splineVertex
on it.._renderer.splineVertex
Snippet:
Reproduction project
The text was updated successfully, but these errors were encountered: