Skip to content

[p5.js 2.0 Bug Report]: 2.0.1 missing type declarations #7789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 17 tasks
Tracked by #279
zenozeng opened this issue May 4, 2025 · 5 comments
Closed
1 of 17 tasks
Tracked by #279

[p5.js 2.0 Bug Report]: 2.0.1 missing type declarations #7789

zenozeng opened this issue May 4, 2025 · 5 comments

Comments

@zenozeng
Copy link
Member

zenozeng commented May 4, 2025

Most appropriate sub-area of p5.js?

  • Accessibility
  • Color
  • Core/Environment/Rendering
  • Data
  • DOM
  • Events
  • Image
  • IO
  • Math
  • Typography
  • Utilities
  • WebGL
  • Build process
  • Unit testing
  • Internationalization
  • Friendly errors
  • Other (specify if possible)

p5.js version

2.0.1

Web browser and version

Chrome 136.0.7103.48 (arm64)

Operating system

MacOS

Steps to reproduce this

Steps:

npm install p5@2.0.1
Image Image
@limzykenneth
Copy link
Member

@zenozeng Thanks for the report. I forgot to include the type generation step in the release CI action so it wasn't included on NPM. I'll add that step but since we can't modify releases once they were released, this will only be fixed in the next version of 2.x.

@limzykenneth
Copy link
Member

@davepagurek While working on this, I've just realized that we are generating the type files into the src folder alongside the source code files themselves, I wonder if it would be better to generate them into the types folder alongside the main entry point to the types? I feel generating into src is a bit noisy but I've seen projects go about this both ways as well.

@davepagurek
Copy link
Contributor

I don't have a strong opinion here, a types folder sounds good to me too!

@limzykenneth
Copy link
Member

Closed with #7802. @zenozeng We'll do a 2.0.2 release soon and please do try it out when we have done so and let us know if there are still any problems. The types are relatively new additions for us so I would expect some stuff would likely still need to be worked out.

@ksen0
Copy link
Member

ksen0 commented May 14, 2025

@zenozeng just a quick ping, this patch is now live in the 2.0.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants