Legacy CLI to handle sketch paths with spaces. #1162
+8
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve clikt help message which is canceled by val help anyway).
Stefterv
approved these changes
Jun 28, 2025
|
Thank you @toniab for this PR! 💙
Is the error the same as in 4.3.4? If so, then we shouldn't really change it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: Issue #1138
Changes: Using arguments.multiple() to pass the argument strings to Commander rather than defining each argument as a Clikt val in advance.
Tests: The following configs worked.
Warning: When testing changes to this file, if you run into an error, try running:
rm -rf /[ YOUR REPOSITORY PATH ]/app/build/compose/tmp
Question: Should we nicely handle if they did not specify a required argument? Right now it errors out if no sketch is passed.