Update the README to reflect the new default for FASTMCP_HOST #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the README to reflect the new default value for FASTMCP_HOST from "0.0.0.0" to "127.0.0.1", addressing issues with the Dockerfile for SSE.
- Updated the configuration table to show the new FASTMCP_HOST default.
- Added a TIP note regarding Docker container network settings.
Comments suppressed due to low confidence (1)
README.md:124
- The Docker run example still sets FASTMCP_HOST to "0.0.0.0", which contradicts the updated default of "127.0.0.1" in the configuration table. Update this command to ensure consistency or clarify the intended behavior in the TIP note.
-e FASTMCP_HOST="0.0.0.0" \
joein
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FastMCP has changed the default value for
FASTMCP_HOSTfrom0.0.0.0to127.0.0.1. That was making the Dockerfile unusable for SSE.Context: https://github.com/jlowin/fastmcp/blame/159324ea468652ec3a86837b0f9f85ce89a795df/src/fastmcp/settings.py#L192