Disable tonic default features who introduces outdated axum #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid having to introduce indirect dependency of axum, which is often not the latest if fron tonic->tower->axum
timvisee
reviewed
Mar 13, 2025
| @@ -13,7 +13,7 @@ categories = ["database", "api-bindings"] | |||
| keywords = ["qdrant", "vector-search", "search-engine", "client", "grpc"] | |||
|
|
|||
| [dependencies] | |||
| tonic = { version = "0.12.3", features = ["tls", "tls-roots", "gzip"] } | |||
| tonic = { version = "0.12.3", default-features = false, features = ["codegen", "prost", "tls", "tls-roots", "gzip"] } | |||
There was a problem hiding this comment.
Is there a reason for not enabling channel as well?
There was a problem hiding this comment.
No, just because it builds and passes all tests. I actually don't know what channel does internally and how it may change user experience or performance. axum is only introduced by router so it's safe to add channel back if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid having to introduce indirect dependency of axum, which is often not the latest if fron
tonic->tower->axum.Say if a downstream project which is a http web server based on axum, but they don't need grpc so as to tonic so they have the latest version of axum(v0.8 as of now). However as
qdrant-clientdepends on tonic thus tower->axum(v0.7), the end project will have two axum dependency.Anyway I think that we don't need server features as a client after all.
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
Have you formatted your code locally usingcargo +nightly fmt --allcommand prior to submission?Have you checked your code usingcargo clippy --all --all-featurescommand?