-
Notifications
You must be signed in to change notification settings - Fork 64
implement conversions for inference objects #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvisee
approved these changes
Jun 17, 2025
Comment on lines
+34
to
+52
pub fn new_from_url(url: impl Into<String>, model: impl Into<String>) -> Self { | ||
Self { | ||
image: Some(Value { | ||
kind: Some(value::Kind::StringValue(url.into())), | ||
}), | ||
model: model.into(), | ||
options: HashMap::new(), | ||
} | ||
} | ||
|
||
pub fn new_from_base64(base64: impl Into<String>, model: impl Into<String>) -> Self { | ||
Self { | ||
image: Some(Value { | ||
kind: Some(value::Kind::StringValue(base64.into())), | ||
}), | ||
model: model.into(), | ||
options: HashMap::new(), | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are basically exactly the same.
Is there any way we want to differentiate them other than the name?
- Maybe validate URL or base64: prefix
- Or explicitly specify the type
timvisee
reviewed
Jun 17, 2025
Co-authored-by: Tim Visée <tim@visee.me>
Co-authored-by: Tim Visée <tim@visee.me>
generall
added a commit
that referenced
this pull request
Jul 14, 2025
* implement conversions for inference objects * fmt * Update src/builders/document_builder.rs Co-authored-by: Tim Visée <tim@visee.me> * Update src/builders/image_builder.rs Co-authored-by: Tim Visée <tim@visee.me> --------- Co-authored-by: Tim Visée <tim@visee.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query with image
Upsert vector from Image