Skip to content

Conversation

ntozaks
Copy link
Contributor

@ntozaks ntozaks commented Jun 9, 2025

Separates client and server port arguments. Now, there are flags outbound-endpoint and sport. outbound-endpoint sets the listening socket for the client given that outbound is set. If not, can pass sport or S to set the listening port for the server. Now, endpoint will always set the client's listening port.

Addresses issue #54

@Aptimex
Copy link
Collaborator

Aptimex commented Jun 9, 2025

Looks like the changes to add_server.go file are related to #53, not #54. Can you separate the changes to that file into a separate PR?

@ntozaks
Copy link
Contributor Author

ntozaks commented Jun 9, 2025

Okay

@Aptimex Aptimex linked an issue Jun 16, 2025 that may be closed by this pull request
Copy link
Collaborator

@Aptimex Aptimex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Aptimex Aptimex merged commit 444c8aa into sandialabs:main Jun 30, 2025
1 check passed
@ntozaks ntozaks deleted the iss54 branch July 28, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate client and server port args for configure (and others)
2 participants