Skip to content

extremely slow Network/Disk IO on Windows agent compared to Ubuntu/Mac #260

@jetersen

Description

@jetersen

Description:

actions/runner-images#3577

Ubuntu agents have slightly higher IOPS disk performance configuration. We use install-dotnet.ps1 script for installation provided by DotNet team . The DownloadFile and Extract-Dotnet-Package functions are being slow. We will investigate how to improve performance those functions if we replace DownloadFile -> WebClient and Extract-Dotnet-Package -> 7zip

DownloadFile and Extract-Dotnet-Package are awfully slow. Like 3x slower!

SLOW

Task version:
v1.9.0

Platform:

  • Ubuntu
    macOS
    Windows

Runner type:

  • Hosted
    Self-hosted

Repro steps:
https://github.com/jetersen/dotnet.restore.slow.github.action

Expected behavior:
Faster downloads

Actual behavior:
SLOW downloads

Activity

jetersen

jetersen commented on Jan 17, 2022

@jetersen
Author

It can be fast:

FAST

jetersen

jetersen commented on Jan 17, 2022

@jetersen
Author

Perhaps consider not using dotnet install script or is the option to contribute a fix to dotnet install script?

vsafonkin

vsafonkin commented on Jan 26, 2022

@vsafonkin

Hi @jetersen, we will try to resolve this problem.

PureKrome

PureKrome commented on Aug 3, 2022

@PureKrome
Contributor

Hi Team - any news on this?

e-korolevskii

e-korolevskii commented on Aug 3, 2022

@e-korolevskii
Contributor

Hello @PureKrome,

So far no updates

self-assigned this
on Sep 25, 2023
dsame

dsame commented on Nov 2, 2023

@dsame

The problem is not reproduced anymore.

Based on multiple runs, the action does not take more than 15 seconds.
https://github.com/akv-demo/dotnet.restore.slow.github.action/actions/runs/6729109167

Most probably, the root cause of the problem was an infrastructure issue that has currently been resolved.

In case the problem reoccurs, the solution is to avoid bulk copying to the OS drive, similar to the workaround applied for the same problem in the actions/setup-go: actions/setup-go#393

@jetersen did it help?

jetersen

jetersen commented on Nov 2, 2023

@jetersen
Author

@dsame I do not agree with the assessment that it is not reproducible 😓
Even with cache available Windows Server 2022 is still 20 seconds slower.
Creating the cache is still 1 minute longer than time of Ubuntu when running Windows Server 2022.

So definitely an improvement but I feel like windows can perform better.

image
image

https://github.com/jetersen/dotnet.restore.slow.github.action/actions/runs/6736238225
https://github.com/jetersen/dotnet.restore.slow.github.action/actions/runs/6736262624

jetersen

jetersen commented on Nov 2, 2023

@jetersen
Author

I don't think it is fair to say look it is fixed for the actions/setup-dotnet when we are talking about a simple if check to see if .NET 6 is already available on the actions runner image 😓

Testing with .NET 8 preview shows ubuntu with 7 seconds vs +30 seconds sometime a little less. For actions/setup-dotnet.

https://github.com/jetersen/dotnet.restore.slow.github.action/actions/runs/6736383956/job/18311632176

While this issue remains open: #141 this will definitely not improve 😢

16 remaining items

priyagupta108

priyagupta108 commented on Dec 4, 2024

@priyagupta108
Contributor

Hi @jetersen 👋,
As mentioned by the runner-images team in this issue comment, unfortunately, there is no simple fix to align the C: drive's performance with the D: drive due to inherent limitations, and these are not expected to be resolved in the near future.

However, a feasible workaround is to set the DOTNET_INSTALL_DIR environment variable to a path on the D: drive to enhance build performance. You can configure it like this:

env:
  DOTNET_INSTALL_DIR: D:\dotnet

Please feel free to reach out if you have any concerns or need additional assistance.
Thanks!

Piedone

Piedone commented on Dec 4, 2024

@Piedone

Thank you! I tested this. Note that this is only applicable to standard (4-core for public, 2-core for private repos) runners, not to larger ones, as those don't have a D drive.

Results are here: It seems to make things slower. What do you think?

priyagupta108

priyagupta108 commented on Dec 9, 2024

@priyagupta108
Contributor

Hi @Piedone,
Thank you for sharing your observations. Could you share the reproduction link or the specific runs used for the performance comparison of the NuGetTest and root workflows? This information would help us better understand the performance results.

Piedone

Piedone commented on Dec 9, 2024

@Piedone

Sure, thank you! In my test, we're building the solution file in the root of our OSOCE project, as well as the solution in the NuGetTest folder. Runs:

You can disregard the failing builds; some parts of the workflow are flaky.

The following steps of the executed jobs are directly using the .NET SDK:

  • Set up .NET: runs setup-dotnet plus some configuration.
  • Build and Static Code Analysis: runs dotnet build and related things.
  • Tests: runs dotnet test for unit and UI tests.
jetersen

jetersen commented on Dec 9, 2024

@jetersen
Author

@priyagupta108 I tested with my repro:
image

There is a definite improvement. But still setup/dotnet install is still incredibly slow when comparing it to Linux or Mac.
So I still think there are improvements to be had in the usage of dotnet-install script.
The difference is Ubuntu 6 seconds vs Windows 16 seconds for the actions/setup-dotnet@v4 run step.
Which shows that install script is doing something it shouldn't.

The .sh relies on curl or wget. Why couldn't Windows rely on curl? GitHub actions runner have curl installed and in my experience avoids any overheads that Powershell or Invoke-WebRequest has when it comes to downloading files.

priyagupta108

priyagupta108 commented on Dec 11, 2024

@priyagupta108
Contributor

Hi @Piedone,
Thank you for sharing the information. Changing the DOTNET_INSTALL_DIR to the D drive has indeed improved the performance for the setup-dotnet step. However, the performance of dotnet build and dotnet test commands may not be significantly impacted by the installation directory of the .NET SDK alone.
To potentially enhance performance further, consider setting the NUGET_PACKAGES environment variable to a directory on the D drive, which may allow faster access to cached packages.

Hi @jetersen,
Thank you for your insights! We will investigate this further and see if we can implement these changes to enhance performance. We will consider this as a potential feature request for future improvements. In the meantime, please feel free to provide any additional details or suggestions you may have.

added
feature requestNew feature or request to improve the current logic
and removed
bugSomething isn't working
on Dec 11, 2024
removed their assignment
on Dec 11, 2024
Piedone

Piedone commented on Dec 11, 2024

@Piedone

Thanks for the tip! This was very useful, since setting NUGET_PACKAGES reduced the workflow runtimes by 14-25%, see Lombiq/GitHub-Actions#402 (comment). I also did a test in a private repo with a .NET Framework build, and got a ~6% reduction there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature requestNew feature or request to improve the current logic

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @dsame@PureKrome@jetersen@Piedone@vsafonkin

      Issue actions

        extremely slow Network/Disk IO on Windows agent compared to Ubuntu/Mac · Issue #260 · actions/setup-dotnet