Bug fix: call get_post_types in hooks.

Author: yoren

README.txt

@@ -5,7 +5,7 @@ Donate link: http://1fix.io/
 Tags: featured image, metabox
 Requires at least: 3.5
 Tested up to: 3.9.1
-Stable tag: 0.9.0
+Stable tag: 0.9.1
 License: GPLv2 or later
 License URI: http://www.gnu.org/licenses/gpl-2.0.html
 
@@ -46,5 +46,5 @@ Custom the title, content and link / button text in the Featured Image metabox.
 
 == Changelog ==
 
-= 0.9.0 =
+= 0.9.1 =
 * The first version

admin/includes/settings.php

@@ -14,8 +14,6 @@ class Custom_Featured_Image_Metabox_Settings {
 	 */
 	protected $plugin_slug = null;
 
-	protected $supported_post_types = null;
-
 	/**
 	 * Instance of this class.
 	 *
@@ -35,7 +33,6 @@ private function __construct() {
 
 		$plugin = Custom_Featured_Image_Metabox::get_instance();
 		$this->plugin_slug = $plugin->get_plugin_slug();
-		$this->supported_post_types = $plugin->supported_post_types();
 
 		// Add settings page
 		add_action( 'admin_init', array( $this, 'admin_init' ) );
@@ -66,7 +63,9 @@ public static function get_instance() {
 	 */
 	public function admin_init() {
 
-		$post_types = $this->supported_post_types;
+		$plugin = Custom_Featured_Image_Metabox::get_instance();
+		$post_types = $plugin->supported_post_types();
+
 		$defaults = array(
 				'title' => '',
 				'instruction' => '',

custom-featured-image-metabox.php

@@ -14,7 +14,7 @@
  * Plugin Name:       Custom Featured Image Metabox
  * Plugin URI:        http://1fix.io
  * Description:       Custom the title, content and link / button text in the Featured Image metabox.
- * Version:           0.9.0
+ * Version:           0.9.1
  * Author:            1fixdotio
  * Author URI:        http://1fix.io
  * Text Domain:       cfim

public/class-custom-featured-image-metabox.php

@@ -28,7 +28,7 @@ class Custom_Featured_Image_Metabox {
 	 *
 	 * @var     string
 	 */
-	const VERSION = '0.9.0';
+	const VERSION = '0.9.1';
 
 	/**
 	 * Unique identifier for your plugin.
@@ -44,15 +44,6 @@ class Custom_Featured_Image_Metabox {
 	 */
 	protected $plugin_slug = 'cfim';
 
-	/**
-	 * Supported post types
-	 *
-	 * @since 0.9.0
-	 *
-	 * @var array
-	 */
-	protected $supported_post_types = null;
-
 	/**
 	 * Instance of this class.
 	 *
@@ -70,8 +61,6 @@ class Custom_Featured_Image_Metabox {
 	 */
 	private function __construct() {
 
-		$this->supported_post_types = $this->supported_post_types();
-
 		// Load plugin text domain
 		add_action( 'init', array( $this, 'load_plugin_textdomain' ) );
 

uninstall.php

@@ -16,8 +16,8 @@
 
 require_once( plugin_dir_path( __FILE__ ) . 'public/class-custom-featured-image-metabox.php' );
 
-$plugin = Completely_Delete::get_instance();
-$post_types = $plugin->supported_post_types;
+$plugin = Custom_Featured_Image_Metabox::get_instance();
+$post_types = $plugin->supported_post_types();
 foreach ( $post_types as $pt ) {
 	delete_option( $plugin->get_plugin_slug() . '_' . $pt );
 }