BUGFIX: Matlab completion now works with structs #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch should fix #52.
The problem was that the MetaKernel framework expects
do_matlab_complete('some_struct.long')
to return'some_struct.long_fieldname'
, but mtFindAllTabCompletions returns'long_fieldname'
instead.This was fixed by asking do_matlab_complete.m to manually re-add the prefix. Matlab's isstruct function is used to make sure that the prefix that's being added back is actually a struct, instead of trying to use regular expressions to find the prefix, since that prevents corner cases where filenames that are valid Matlab identifiers are confused for structs that don't exist.
In practice, this means autocompletion will work correctly on
test.p[TAB]
whethertest.py
is a script in the current directory, a fieldpy
of the structtest
, or both.Also corrected some tab/spaces inconsistencies in the relevant files, and did some more name mangling to make sure that
evalin(base, ...
doesn't cause any problems if the user has a variable named e.g.completions_output
.