-
Notifications
You must be signed in to change notification settings - Fork 1.4k
pimd, pim6d: route-map filtering for source/group #18955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cb14c3c
to
6cfd913
Compare
9fed961
to
f0f3dda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me beyond the topotest failure, looks like there may be a couple places the previous multicast boundary wasn't being checked but should have been but that's a separate issue from the route-map functionality in this PR.
@rzalamena , one minor nit from frrbot, otherwise this is good to go.
|
Change the `struct in_addr` field to a `struct ipaddr` so we can also support prefix_sg with IPv6 groups. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
New YANG model for PIM route map support: support filtering on multicast group, multicast source or multicast interface. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Add the code needed to display the route map new leaves. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Allow the PIM6d daemon to receive commands that manipulate route-map and prefix list. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Code to implement the commands and route maps callbacks. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
New interface configuration to filter IGMP joins based on source / group. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
New interface configuration to filter MLD joins based on source / group. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Implement tests for the new multicast route-map filtering. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Update: the new topotest is failing on i386 consistently due to python magic in
|
The group_source_req structure in 32bit has different fields/sizes so we must account that. Check if running 32bit then use the 32bit version of the packed structure. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
I fixed the multicast tester issue and now the test is passing on i386. |
Thanks @rzalamena . I will merge this PR, but do we need to backport the fix to 10.4? |
No, this fix is for this new test using IPv6 MLD SG join. Previously nobody else was doing IPv6 MLD join with source and group using |
Implement route-map support for PIM / PIMv6 to allow users to filter IGMP / MLD joins using source / group / interface combinations.