Skip to content

Squash pre-4.x database migrations #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 30, 2025

Conversation

williamjallen
Copy link
Collaborator

@williamjallen williamjallen commented May 30, 2025

Laravel changed the way database migrations are written, meaning that our existing migrations will no longer work. Instead of rewriting every migration, this PR squashes them into a single schema dump. Doing so means that users will have to upgrade to 4.0 prior to upgrading to 4.1+.

Closes #2705.

Squashing the migrations changed the test order, leading to a higher flake rate for browser tests.
Removing the migrations apparently allows PHPStan to do a more thorough analysis of `app/Utils/TestCreator.php`...
@williamjallen williamjallen added this pull request to the merge queue May 30, 2025
Merged via the queue into Kitware:master with commit 1751400 May 30, 2025
7 checks passed
@williamjallen williamjallen deleted the squash-migrations branch May 30, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Squash pre-4.0 migrations
3 participants