Skip to content

Remove sendemail.php #2919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 3, 2025
Merged

Conversation

williamjallen
Copy link
Collaborator

Each of the functions in sendemail.php is only used once. This PR moves each function to the class in which it is called, and removes sendemail.php.

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No issues with emails sent by test instances

@josephsnyder josephsnyder added this pull request to the merge queue Jun 3, 2025
Merged via the queue into Kitware:master with commit 4dcd576 Jun 3, 2025
7 checks passed
@williamjallen williamjallen deleted the remove-sendemail branch June 3, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants