Clean up legacy test dependencies #2925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephsnyder
approved these changes
Jun 10, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
This PR supersedes #2903, moving tests which have no dependencies to the parallel section at the beginning of the test suite instead of creating parallel blocks in the middle of the test suite. This approach is far safer than the aggressive approach taken in #2903, reducing the chances of additional flakiness being introduced. In addition to improving the overall test time, these changes make it easier to debug tests late in the test by reducing the length of the longest dependency chain.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #2903, moving tests which have no dependencies to the parallel section at the beginning of the test suite instead of creating parallel blocks in the middle of the test suite. This approach is far safer than the aggressive approach taken in #2903, reducing the chances of additional flakiness being introduced. In addition to improving the overall test time, these changes make it easier to debug tests late in the test by reducing the length of the longest dependency chain.