Skip to content

Restore support for log levels #2931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

Restore support for log levels #2931

merged 1 commit into from
Jun 11, 2025

Conversation

zackgalbreath
Copy link
Contributor

When CDash initially adopted Laravel, minimum log message severity was controlled by the APP_LOG_LEVEL environment variable.

This behavior changed in Laravel v5.6.0, and we should be using LOG_LEVEL instead now.

This commit updates config/logging.php from the upstream Laravel 11.x branch. The only change made to the upstream copy is replacing laravel.log with cdash.log.

@zackgalbreath
Copy link
Contributor Author

For posterity's sake, here's the Laravel commit where APP_LOG_LEVEL was removed:

laravel/laravel@acabdff

When CDash initially adopted Laravel, minimum log message severity
was controlled by the `APP_LOG_LEVEL` environment variable.

This behavior changed in Laravel v5.6.0, and we should be using
`LOG_LEVEL` instead now.

This commit updates `config/logging.php` from the upstream Laravel
11.x branch. The only change made to the upstream copy is replacing
`laravel.log` with `cdash.log`.
@zackgalbreath zackgalbreath added this pull request to the merge queue Jun 11, 2025
Merged via the queue into master with commit f8a7be0 Jun 11, 2025
13 of 14 checks passed
@zackgalbreath zackgalbreath deleted the support_log_levels branch June 11, 2025 20:23
@williamjallen williamjallen added this to the v4.2 milestone Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants