Skip to content

Move data providers to PHP attributes #2940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

williamjallen
Copy link
Collaborator

PHPUnit 12 removes support for doc comment parsing, instead using PHP's attributes to do the same thing. This PR converts all of our data provider doc comments to PHP attributes in preparation for our upcoming migration to PHPUnit 12.

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more messages in the output like can be seen in previous runs. LGTM!

@josephsnyder josephsnyder added this pull request to the merge queue Jun 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 16, 2025
@williamjallen williamjallen added this pull request to the merge queue Jun 16, 2025
Merged via the queue into Kitware:master with commit 723138d Jun 16, 2025
7 checks passed
@williamjallen williamjallen deleted the data-provider-attributes branch June 16, 2025 15:58
github-merge-queue bot pushed a commit that referenced this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants