-
Notifications
You must be signed in to change notification settings - Fork 612
feat: multimodal embeddings for bedrock titan and cohere #1130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: multimodal embeddings for bedrock titan and cohere #1130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds multimodal embedding support for Bedrock Titan and Cohere providers, allowing both text and image inputs. The implementation is well-structured, but I've identified a few improvements that could enhance error handling and type safety.
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
input_type: { | ||
param: 'input_type', | ||
required: false, | ||
}, | ||
embedding_types: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep the support for embedding_types param as well for now? Don't want this to become a breaking change for anyone. We can do another release which removes it along with a notice
This PR adds support for multimodal embeddings in compliance with the portkey signature:
example requests: