Skip to content

chore: update devDependencies and configurations #7662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Jun 6, 2025

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

update vite dependency to latest version and add changeset for compatibility

"peerDependencies": {
    "prettier": "*",
    "vite": ">=5 <7",
    "vitest": ">=2 <3"
  },

main pack(qwik core) was already 5-6 vite version

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

Copy link

changeset-bot bot commented Jun 6, 2025

🦋 Changeset detected

Latest commit: 8a83ab0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JerryWu1234 JerryWu1234 marked this pull request as ready for review June 6, 2025 09:33
@JerryWu1234 JerryWu1234 requested a review from a team as a code owner June 6, 2025 09:33
@JerryWu1234 JerryWu1234 self-assigned this Jun 6, 2025
Copy link

pkg-pr-new bot commented Jun 6, 2025

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7662
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7662
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7662
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7662

commit: 8a83ab0

Copy link
Contributor

github-actions bot commented Jun 6, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 8a83ab0

@JerryWu1234 JerryWu1234 moved this from Backlog to Waiting For Review in Qwik Development Jun 9, 2025
@JerryWu1234 JerryWu1234 marked this pull request as draft June 9, 2025 10:27
@JerryWu1234 JerryWu1234 marked this pull request as ready for review June 10, 2025 02:03
@JerryWu1234 JerryWu1234 removed the status in Qwik Development Jun 10, 2025
@JerryWu1234 JerryWu1234 moved this to Waiting For Review in Qwik Development Jun 10, 2025
@wmertens
Copy link
Member

can you adjust https://github.com/QwikDev/qwik/blob/main/package.json#L21 as well? and run pnpx syncpack-fix-mismatches afterwards

@JerryWu1234
Copy link
Contributor Author

can you adjust https://github.com/QwikDev/qwik/blob/main/package.json#L21 as well? and run pnpx syncpack-fix-mismatches afterwards

also latest version ?
"pinVersion": "latest "

@wmertens

@wmertens
Copy link
Member

ah actually I'm wrong, that shouldn't change

@wmertens
Copy link
Member

wmertens commented Jun 24, 2025

@JerryWu1234 this needs to be changed to allow 5 and 6:

"vite": "^5"

Careful, the syntax is weird.

Ah - and that is controlled by that syncpack config, so I was right after all. So make it ">= 5, <7" or something like that, test that it works.

@JerryWu1234
Copy link
Contributor Author

@JerryWu1234 this needs to be changed to allow 5 and 6:

"vite": "^5"

Careful, the syntax is weird.

Ah - and that is controlled by that syncpack config, so I was right after all. So make it ">= 5, <7" or something like that, test that it works.

@JerryWu1234 this needs to be changed to allow 5 and 6:

"vite": "^5"

Careful, the syntax is weird.

Ah - and that is controlled by that syncpack config, so I was right after all. So make it ">= 5, <7" or something like that, test that it works.

I saw you already fixed

@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants