-
Notifications
You must be signed in to change notification settings - Fork 16
RK-19777 - remove sentry #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Github Enforcer opened Task: RK-19777 |
from jaeger_client import Config | ||
from flask_opentracing import FlaskTracer | ||
from utils.logging import on_add_todo_logging, on_get_todos_logging | ||
import os | ||
from flask import send_from_directory | ||
|
||
sentry_sdk.init( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dont we need to recalculate the hash of the file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true true, fixed
@@ -6,19 +6,12 @@ | |||
from datetime import datetime | |||
from random import randint | |||
from todos_store import Store | |||
import sentry_sdk | |||
from sentry_sdk.integrations.flask import FlaskIntegration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no,
Just realized our e2es rely on things being in specific lines. So, removing lines will break e2es. Lets leave the removed lines empty insteqd of removing them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do e2e with tutorial-python?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Urook ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ElDuderinos Yes, in profiling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, done
app.py
Outdated
@@ -7,17 +7,17 @@ | |||
from random import randint | |||
from todos_store import Store | |||
import sentry_sdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aha, sorry good catch, removed
No description provided.